Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace phone strings with list of phones for remote user #277

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: replace phone strings with list of phones for remote user #277

merged 1 commit into from
Jan 16, 2025

Conversation

tessstoddard
Copy link
Contributor

@tessstoddard tessstoddard commented Jan 16, 2025 •
edited
Loading

Summary of Changes

Reverts these changes I made the other day #273. And replaces with a list of phones. Requirements changed and we need to return multiple of the same phone type. A list of phones allows that.

How Has This Been Tested?

I pulled this into gcu and verified it works correctly with NATs calls

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

meotch
meotch approved these changes Jan 16, 2025
View reviewed changes
Copy link

@meotch meotch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of unused homePhone, mobilePhone, workPhone approved

@tessstoddard tessstoddard merged commit 315fd66 into master Jan 16, 2025
4 checks passed
@tessstoddard tessstoddard deleted the tess/remote_user_phones_fix branch January 16, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meotch meotch meotch approved these changes

@stevecl5 stevecl5 stevecl5 approved these changes

@mattnichols mattnichols Awaiting requested review from mattnichols mattnichols is a code owner

@gerfboy gerfboy Awaiting requested review from gerfboy gerfboy is a code owner

@RyanJones08 RyanJones08 Awaiting requested review from RyanJones08 RyanJones08 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tessstoddard @meotch @stevecl5